Page MenuHomePhabricator

[guix] Consistently use FHS for all targets
Changes PlannedPublic

Authored by Fabien on Wed, Nov 27, 20:15.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This requires a bump in the time machine commit to a bugfix commit for OSX, and to bump the clang version (version 15 is used).

Test Plan

Run the GUIX builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
guix_all_fhs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31355
Build 62208: Build Diff
Build 62207: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Wed, Nov 27, 20:15
Fabien planned changes to this revision.Wed, Nov 27, 20:15

Let see if it builds

@bot guix-linuw guix-osx guix-win

Tail of the build log:

if [ -f ~/.bashrc ]; then
source ~/.bashrc
fi

mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "guix-linuw"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh \
  -r "${REGISTRY}" \
  abc-base-image-"${HASH}" ./run-command.sh

[20:31:53] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script3624920845627857948 
[20:31:53] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[20:31:53]W:	 [Step 1/1] + '[' -z guix-linuw ']'
[20:31:53]W:	 [Step 1/1] + case guix-linuw in
[20:31:53]W:	 [Step 1/1] + unset BASE_CACHE
[20:31:53]W:	 [Step 1/1] + unset SDK_ARCHIVE_DIR
[20:31:53]W:	 [Step 1/1] + unset SOURCES_PATH
[20:31:53]W:	 [Step 1/1] + pushd bitcoin-abc
[20:31:53]W:	 [Step 1/1] + ./contrib/teamcity/build-configurations.py guix-linuw
[20:31:53] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[20:31:53]W:	 [Step 1/1] Traceback (most recent call last):
[20:31:53]W:	 [Step 1/1]   File "/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc/./contrib/teamcity/build-configurations.py", line 735, in <module>
[20:31:53]W:	 [Step 1/1]     main()
[20:31:53]W:	 [Step 1/1]   File "/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc/./contrib/teamcity/build-configurations.py", line 724, in main
[20:31:53]W:	 [Step 1/1]     build_configuration = BuildConfiguration(script_dir, config_path, args.build)
[20:31:53]W:	 [Step 1/1]   File "/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc/./contrib/teamcity/build-configurations.py", line 67, in __init__
[20:31:53]W:	 [Step 1/1]     self.load(build_name)
[20:31:53]W:	 [Step 1/1]   File "/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc/./contrib/teamcity/build-configurations.py", line 87, in load
[20:31:53]W:	 [Step 1/1]     raise AssertionError(
[20:31:53]W:	 [Step 1/1] AssertionError: guix-linuw is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[20:31:53]W:	 [Step 1/1] + RESULT=1
[20:31:53]W:	 [Step 1/1] + popd
[20:31:53]W:	 [Step 1/1] + exit 1
[20:31:53] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[20:31:53]W:	 [Step 1/1] Process exited with code 1
[20:31:54]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[20:31:54]E:	 [Step 1/1] Step Command Line failed
[20:31:55]E: Ant JUnit report watcher
[20:31:55]E:	 [Ant JUnit report watcher] No reports found for paths:
[20:31:55]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[20:31:55]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[20:31:55]E:	 [Ant JUnit report watcher] +:results/**/*junit.xml
[20:31:55] : Publishing internal artifacts
[20:31:55] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[20:31:55] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisherImpl]
[20:31:55]i:	 [Publishing internal artifacts] Will publish 1 artifact(s) to TeamCity node with id MAIN_SERVER
[20:31:55] : Publishing internal artifacts
[20:31:55]W: Publishing artifacts
[20:31:55] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml, +:bitcoin-abc/abc-ci-builds/guix-linuw/gitian-results => guix-linuw.tar.gz, +:bitcoin-abc/abc-ci-builds/guix-linuw/*.log => artifacts.tar.gz, +:bitcoin-abc/abc-ci-builds/guix-linuw/guix-results => guix-linuw.tar.gz]
[20:31:55]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[20:31:55]W:	 [Publishing artifacts] Artifacts path 'bitcoin-abc/abc-ci-builds/guix-linuw/gitian-results' not found
[20:31:55]W:	 [Publishing artifacts] Artifacts path 'bitcoin-abc/abc-ci-builds/guix-linuw/guix-results' not found
[20:31:55]W:	 [Publishing artifacts] Artifacts path 'bitcoin-abc/abc-ci-builds/guix-linuw/*.log' not found
[20:31:56] : Build finished

Tail of the build log:

-- Performing Test have_CXX__Wno_inconsistent_missing_override - Success
-- Performing Test have_CXX__Wno_maybe_uninitialized
-- Performing Test have_CXX__Wno_maybe_uninitialized - Success
-- Performing Test have_CXX__Wno_shadow
-- Performing Test have_CXX__Wno_shadow - Success
-- Performing Test have_CXX__Wno_sign_compare
-- Performing Test have_CXX__Wno_sign_compare - Success
-- Performing Test have_CXX__Wno_unused_const_variable
-- Performing Test have_CXX__Wno_unused_const_variable - Success
-- Performing Test have_CXX__Wno_conditional_uninitialized
-- Performing Test have_CXX__Wno_conditional_uninitialized - Success
-- Performing Test have_C__Wno_strict_prototypes
-- Performing Test have_C__Wno_strict_prototypes - Success
-- Looking for C++ include atomic
-- Looking for C++ include atomic - found
-- Found SHLWAPI component shlwapi: /gnu/store/84slgaixl8imh4ajg7pppm5c360abglr-mingw-w64-x86_64-winpthreads-12.0.0/lib/libshlwapi.a
-- Found SHLWAPI: /gnu/store/84slgaixl8imh4ajg7pppm5c360abglr-mingw-w64-x86_64-winpthreads-12.0.0/include   
-- Performing Test ENABLE_HWCRC32
-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wshadow
-- Performing Test have_C__Wshadow - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found PkgConfig: /home/bitcoinabc/.guix-profile/bin/pkg-config (found version "0.29.2") 
-- Found Event component event: /bitcoin/depends/x86_64-w64-mingw32/lib/libevent.a
-- Found Event: /bitcoin/depends/x86_64-w64-mingw32/include (found suitable version "99.99.99", minimum required is "2.0.22") found components: event 
-- Found Boost: /bitcoin/depends/x86_64-w64-mingw32/include (found suitable version "1.81.0", minimum required is "1.64")  
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Performing Test fuzz_target_builds_without_main_fuzz
-- Performing Test fuzz_target_builds_without_main_fuzz - Failed
-- Configuring native build in /bitcoin/source_package/native
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/source_package
[0/1] Run CPack packaging tool for source...
CPack: Create package using TGZ
CPack: Install projects
CPack: - Install directory: /bitcoin
CPack: Create package
CPack: - package: /bitcoin/source_package/bitcoin-abc-0.30.5.tar.gz generated.
/bitcoin
cmake: /gnu/store/ddx1hinr7hc905xh4dk1g2asgrg7290p-gcc-toolchain-10.5.0/lib/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by cmake)
cmake: /gnu/store/ddx1hinr7hc905xh4dk1g2asgrg7290p-gcc-toolchain-10.5.0/lib/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by /gnu/store/203b3ywi605aimfmbfhxm0dz9jfak3v2-jsoncpp-1.9.5/lib/libjsoncpp.so.25)
Build guix-win failed with exit code 1