Page MenuHomePhabricator
Differential D17225

[ecash-herald] Parse ALP token actions
AcceptedPublic
Actions

Authored by bytesofman on Thu, Nov 28, 14:14.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Summary

Parse ALP token actions. These are similar enough to SLP fungible that we can extend that existing parsing to include ALP.

Stop listing generic ALP tx count. Include the ALP icon next to line items that feature ALP.

Accept tokensToShow param in summarizeTxHistory so we can include more lines in the unit tests and show all tested tokens.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-dailies-alp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31369
Build 62236: Build Diffecash-herald-tests
Build 62235: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Nov 28, 14:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 28, 14:14
Harbormaster completed remote builds in B31369: Diff 51172.Thu, Nov 28, 14:16
bytesofman updated this revision to Diff 51174.Thu, Nov 28, 14:19

remove todo comments, improve listing checking logic, change slp-specific variable to be more accurate with current parsing

Harbormaster completed remote builds in B31371: Diff 51174.Thu, Nov 28, 14:21
bytesofman published this revision for review.Thu, Nov 28, 14:29
PiRK accepted this revision.Fri, Nov 29, 08:37
This revision is now accepted and ready to land.Fri, Nov 29, 08:37

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
scripts/
1 line
src/
2 lines
197 lines
test/
mocks/
800 lines
54 lines

Diff 51172

View Options

apps/ecash-herald/scripts/getDailySummary.ts

Loading...
View Options

apps/ecash-herald/src/events.ts

Loading...
View Options

apps/ecash-herald/src/parse.ts

Loading...
View Options

apps/ecash-herald/test/mocks/dailyTxs.ts

Loading...
View Options

apps/ecash-herald/test/parse.test.ts

Loading...