Make the constructor taking satoshi as parameter from the Amount class private
ClosedPublic
Actions

Authored by deadalnix on Sep 5 2018, 14:28.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING16fc2789194a: Make the constructor taking satoshi as parameter from the Amount class private
rABC16fc2789194a: Make the constructor taking satoshi as parameter from the Amount class private

Summary

This remove assumption from the codebase that Amunt are denominated in satoshi.

Depends on D1718, D1711, D1712 and D1722

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

nointamountctor

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3200
Build 4487: Bitcoin ABC Buildbot (legacy)
Build 4486: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 5 2018, 14:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2018, 14:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3200: Diff 4771!Sep 5 2018, 14:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox accepted this revision.Sep 5 2018, 16:52

This revision is now accepted and ready to land.Sep 5 2018, 16:52

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3208: Diff 4784.Sep 6 2018, 13:29

Closed by commit rABC16fc2789194a: Make the constructor taking satoshi as parameter from the Amount class private (authored by deadalnix). · Explain WhySep 6 2018, 15:11

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

amount.h

8 lines

Diff 4771

View Options

Make the constructor taking satoshi as parameter from the Amount class privateClosedPublicActions