Differential D17248

Fix a linkage error when cross building for windows with the hardening flags
ClosedPublic
Actions

Authored by Fabien on Fri, Nov 29, 15:31.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC669ebc5fb537: Fix a linkage error when cross building for windows with the hardening flags

Summary

The linker is missing the hardened functions when _FORTIFY_SOURCE > 0.
It used to be supplied by libssp that was removed in D17229, but this implies the use of mingw >= 11 when we still use 10 for most of our CI. Let's keep this linked in for now and improve the comment.

Test Plan

Run the cross windows build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Fri, Nov 29, 15:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 29, 15:31

Fabien requested review of this revision.Fri, Nov 29, 15:31

Harbormaster completed remote builds in B31401: Diff 51226.Fri, Nov 29, 16:18

PiRK accepted this revision.Fri, Nov 29, 16:55

This revision is now accepted and ready to land.Fri, Nov 29, 16:55

Closed by commit rABC669ebc5fb537: Fix a linkage error when cross building for windows with the hardening flags (authored by Fabien). · Explain WhyFri, Nov 29, 17:44

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC669ebc5fb537: Fix a linkage error when cross building for windows with the hardening flags.

Revision Contents
Changeset List

Path

Size

src/

8 lines

Diff 51236

src/CMakeLists.txt

Loading...