Page MenuHomePhabricator

Fix a linkage error when cross building for windows with the hardening flags
ClosedPublic

Authored by Fabien on Fri, Nov 29, 15:31.

Details

Summary

The linker is missing the hardened functions when _FORTIFY_SOURCE > 0.
It used to be supplied by libssp that was removed in D17229, but this implies the use of mingw >= 11 when we still use 10 for most of our CI. Let's keep this linked in for now and improve the comment.

Test Plan

Run the cross windows build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_windows_linkage_hardening
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31401
Build 62300: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 62299: arc lint + arc unit