Differential D17253

build: fix mutex detection when building bdb on macOS
ClosedPublic
Actions

Authored by Fabien on Fri, Nov 29, 17:41.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC8fc7a3d8a370: build: fix mutex detection when building bdb on macOS

Summary

Starting with the Clang shipped with Xcode 12, Apple has enabled
-Werror=implicit-function-declaration by default. This causes bdbs mutex
detection to fail when building on macOS (not cross-compiling):

checking for mutexes... UNIX/fcntl
configure: WARNING: NO SHARED LATCH IMPLEMENTATION FOUND FOR THIS PLATFORM.
configure: error: Unable to find a mutex implementation

Backport of core#20195.

Test Plan

Run the guix osx build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR20195

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31409
Build 62316: Build Diff
Build 62315: arc lint + arc unit

Event Timeline

Fabien created this revision.Fri, Nov 29, 17:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 29, 17:41

Fabien requested review of this revision.Fri, Nov 29, 17:41

teamcity edited the summary of this revision. (Show Details)Fri, Nov 29, 17:41

Harbormaster completed remote builds in B31409: Diff 51235.Fri, Nov 29, 17:41

PiRK accepted this revision.Fri, Nov 29, 19:04

This revision is now accepted and ready to land.Fri, Nov 29, 19:04

Closed by commit rABC8fc7a3d8a370: build: fix mutex detection when building bdb on macOS (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyFri, Nov 29, 19:10

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8fc7a3d8a370: build: fix mutex detection when building bdb on macOS.

Revision Contents
Changeset List

Path

Size

depends/

packages/

1 line

Diff 51235

depends/packages/bdb.mk

Loading...