Page MenuHomePhabricator

Fix importmulti failure to return rescan errors
ClosedPublic

Authored by deadalnix on Sep 6 2018, 12:47.

Details

Summary

An off-by-one-block bug in importmulti rescan logic could cause it to return
success in an edge case even when a rescan was not successful. The case where
this would happen is if there were multiple blocks in a row with the same
GetBlockTimeMax() value, and the last block was scanned successfully, but one
or more of the earlier blocks was not readable.

This is backport of core's PR10403

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr10403
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3207
Build 4501: Bitcoin ABC Buildbot (legacy)
Build 4500: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 6 2018, 19:45
This revision was automatically updated to reflect the committed changes.