Differential D17277

[cmake] Fix -Wunused-command-line-argument with clang
ClosedPublic
Actions

Authored by Fabien on Mon, Dec 2, 21:59.

Details

Reviewers

tobias_ruck

Group Reviewers

Restricted Project

Commits

rABC68549714ac4e: [cmake] Fix -Wunused-command-line-argument with clang

Summary

This especially happen for -fstack-clash-protection which is not detected as unused. See https://gitlab.kitware.com/cmake/cmake/-/issues/21998.

Test Plan

Run the guix osx build and check for no warning

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_unused_arg_warning

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31485
Build 62467: Build Diff	build-clang · build-debug · build-diff · build-clang-tidy · build-without-wallet
Build 62466: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, Dec 2, 21:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 2, 21:59

Fabien requested review of this revision.Mon, Dec 2, 21:59

Harbormaster completed remote builds in B31485: Diff 51344.Mon, Dec 2, 22:18

works for me

This revision is now accepted and ready to land.Mon, Dec 2, 22:25

Closed by commit rABC68549714ac4e: [cmake] Fix -Wunused-command-line-argument with clang (authored by Fabien). · Explain WhyTue, Dec 3, 08:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC68549714ac4e: [cmake] Fix -Wunused-command-line-argument with clang.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

AddCompilerFlags.cmake

8 lines

Diff 51344

View Options

cmake/modules/AddCompilerFlags.cmake

[cmake] Fix -Wunused-command-line-argument with clangClosedPublicActions