Paths

Table of Contentst

Differential D17279

[mock-chronik-client] Add new dummy method to allow Agora construction with MockChronikClient
ClosedPublic
Actions

Authored by bytesofman on Tue, Dec 3, 04:57.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC737cc2ec931b: [mock-chronik-client] Add new dummy method to allow Agora construction with…

Summary

We add this method in Cashtab tests. Would be nice if it were handled in the lib.

We can't test this here without adding the whole ecash-agora dep to this lib, which is imo not worth it.

Verify that it doesn't break this with current tests passing.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Tue, Dec 3, 04:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 3, 04:57

remove the dummy shim in Cashtab

Harbormaster completed remote builds in B31490: Diff 51350.Tue, Dec 3, 05:17

Harbormaster completed remote builds in B31492: Diff 51352.

bytesofman published this revision for review.Tue, Dec 3, 05:49

emack accepted this revision.Tue, Dec 3, 07:35

This revision is now accepted and ready to land.Tue, Dec 3, 07:35

Closed by commit rABC737cc2ec931b: [mock-chronik-client] Add new dummy method to allow Agora construction with… (authored by bytesofman). · Explain WhyTue, Dec 3, 14:13

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC737cc2ec931b: [mock-chronik-client] Add new dummy method to allow Agora construction with….

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Agora/

__tests__/

index.test.js

4 lines

Etokens/

__tests__/

TokenActions.test.js

8 lines

modules/

mock-chronik-client/

4 lines

4 lines

4 lines

2 lines

Diff 51376

View Options

cashtab/src/components/Agora/tests/index.test.js

View Options

cashtab/src/components/Etokens/tests/TokenActions.test.js

View Options

modules/mock-chronik-client/README.md

View Options

modules/mock-chronik-client/index.js

View Options

modules/mock-chronik-client/package-lock.json

View Options

modules/mock-chronik-client/package.json

[mock-chronik-client] Add new dummy method to allow Agora construction with MockChronikClientClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51376

cashtab/src/components/Agora/__tests__/index.test.js

cashtab/src/components/Etokens/__tests__/TokenActions.test.js

modules/mock-chronik-client/README.md

modules/mock-chronik-client/index.js

modules/mock-chronik-client/package-lock.json

modules/mock-chronik-client/package.json

[mock-chronik-client] Add new dummy method to allow Agora construction with MockChronikClient
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Agora/tests/index.test.js

cashtab/src/components/Etokens/tests/TokenActions.test.js