Differential D17286

[cashtab] Menu style edit
ClosedPublic
Actions

Authored by johnkuney on Tue, Dec 3, 16:16.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf7971f780daf: [cashtab] Menu style edit

Summary

Adding a background hover effect to the menu items and fixing the label line heights so they are
exactly aligned center with the icon

Test Plan

npm start and check it out

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cashtab-menu-hover

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31506
Build 62509: Build Diff	cashtab-tests
Build 62508: arc lint + arc unit

Event Timeline

johnkuney created this revision.Tue, Dec 3, 16:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 3, 16:16

johnkuney requested review of this revision.Tue, Dec 3, 16:16

Harbormaster completed remote builds in B31504: Diff 51377.Tue, Dec 3, 16:20

bytesofman accepted this revision.Tue, Dec 3, 17:18

This revision is now accepted and ready to land.Tue, Dec 3, 17:18

version patch

Harbormaster completed remote builds in B31506: Diff 51379.Tue, Dec 3, 17:27

Closed by commit rABCf7971f780daf: [cashtab] Menu style edit (authored by johnkuney). · Explain WhyTue, Dec 3, 17:28

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCf7971f780daf: [cashtab] Menu style edit.

Revision Contents
Changeset List

Path

Size

cashtab/

package-lock.json

4 lines

package.json

2 lines

src/

components/

App/

styles.js

10 lines

Diff 51379

View Options

cashtab/package-lock.json

View Options

cashtab/package.json

View Options

cashtab/src/components/App/styles.js

[cashtab] Menu style editClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51379

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/App/styles.js

[cashtab] Menu style edit
ClosedPublic
Actions

Revision Contents
Changeset List