Page MenuHomePhabricator
Differential D17290

[64-bit ints] Add script_tests for `getint` coverage
ClosedPublic
Actions

Authored by tobias_ruck on Wed, Dec 4, 22:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf67fd8dd5fd8: [64-bit ints] Add script_tests for `getint` coverage
Summary

Currently, all the getint calls in interpreter.cpp don't have coverage for very large integers that might overflow.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Wed, Dec 4, 22:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Dec 4, 22:33
tobias_ruck requested review of this revision.Wed, Dec 4, 22:33
Harbormaster completed remote builds in B31515: Diff 51393.Wed, Dec 4, 22:55
tobias_ruck added a child revision: D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.Wed, Dec 4, 23:18
Fabien requested changes to this revision.Thu, Dec 5, 09:23
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/data/script_tests.json
529–545 ↗(On Diff #51393)

Please add a "rationale" to your test cases

989–992 ↗(On Diff #51393)

A bit clearer imo

This revision now requires changes to proceed.Thu, Dec 5, 09:23
tobias_ruck updated this revision to Diff 51411.Thu, Dec 5, 17:14

add rationales

Harbormaster completed remote builds in B31531: Diff 51411.Thu, Dec 5, 17:33
Fabien accepted this revision.Thu, Dec 5, 19:19
Fabien added inline comments.
src/test/data/script_tests.json
1072 ↗(On Diff #51411)

This one is missing

1075 ↗(On Diff #51411)

dito

This revision is now accepted and ready to land.Thu, Dec 5, 19:19
Closed by commit rABCf67fd8dd5fd8: [64-bit ints] Add script_tests for `getint` coverage (authored by tobias_ruck). · Explain WhyThu, Dec 5, 23:48
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCf67fd8dd5fd8: [64-bit ints] Add script_tests for `getint` coverage.

Revision Contents
Changeset List

PathSize
src/
test/
data/
50 lines

Diff 51428

View Options

src/test/data/script_tests.json

Loading...