[BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer
ClosedPublic
Actions

Authored by hazzarust on Thu, Dec 5, 03:34.

Details

Reviewers

tobias_ruck
Fabien

Group Reviewers

Restricted Project
Restricted Owners Package	(Owns No Changed Paths)

Commits

rABCeb72bf2569f8: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer

Summary

This error appears in the output section on VScode:

2024-12-05T03:00:51.754466Z ERROR notification handler failed handler=textDocument/didSave error=file not found: /Users/hazza/bitcoin-abc/web/explorer/explorer-exe/Cargo.toml

Removed the Cargo.toml + Cargo.lock file in explorer and appended the 'Cargo.toml paths for explorer-exe && explorer-server into the main workspace in bitcoin-abc/Cargo.toml

This allowed rust analyzer to work on .rs files inside the explorer dir.

Test Plan

ninja check-functional cargo check cargo run

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hazzarust created this revision.Thu, Dec 5, 03:34

Owners added a reviewer: Restricted Owners Package.Thu, Dec 5, 03:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Dec 5, 03:34

hazzarust edited the summary of this revision. (Show Details)Thu, Dec 5, 03:41

hazzarust edited the test plan for this revision. (Show Details)

hazzarust edited reviewers, added: tobias_ruck; removed: Restricted Owners Package, Restricted Project.

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Dec 5, 03:41

Harbormaster completed remote builds in B31523: Diff 51402.Thu, Dec 5, 03:58

Changing the config.toml path back. People are expected to modify it

Owners added a reviewer: Restricted Owners Package.Thu, Dec 5, 12:29

hazzarust edited the summary of this revision. (Show Details)Thu, Dec 5, 12:30

hazzarust edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B31526: Diff 51405.Thu, Dec 5, 12:52

hazzarust edited the summary of this revision. (Show Details)Fri, Dec 6, 01:12

hazzarust removed a reviewer: Restricted Owners Package.

hazzarust published this revision for review.Fri, Dec 6, 01:20

hazzarust edited the summary of this revision. (Show Details)

hazzarust retitled this revision from Changes to rust analyzer to [BITCOIN-ABC] Changes to rust analyser.

hazzarust edited the summary of this revision. (Show Details)

hazzarust edited the summary of this revision. (Show Details)Fri, Dec 6, 01:23

hazzarust retitled this revision from [BITCOIN-ABC] Changes to rust analyser to [BITCOIN-ABC] Allowing rust analyser to work in web/explorer.Fri, Dec 6, 01:26

hazzarust retitled this revision from [BITCOIN-ABC] Allowing rust analyser to work in web/explorer to [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer.

hazzarust edited the summary of this revision. (Show Details)Fri, Dec 6, 01:31

@bot preview-explorer

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.83.66.92:41474 for the next 60 minutes.

This doesn't break the explorer deployment because it doesn't use the --locked flag. In a follow-up @hazzarust can you update the Dockerfile to use the --locked flag ? This will require to:

move it to the root so the Cargo.lock is in the docker context
update the build-configurations.yml to use the appropriated file in the preview-explorer build

This revision is now accepted and ready to land.Fri, Dec 6, 21:04

Closed by commit rABCeb72bf2569f8: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer (authored by hazzarust). · Explain WhySat, Dec 7, 13:00

This revision was automatically updated to reflect the committed changes.

hazzarust added a commit: rABCeb72bf2569f8: [BITCOIN-ABC][WEB] Allowing rust analyser to work in web/explorer.

Owners added a reviewer: Restricted Owners Package.Sat, Dec 7, 13:00

bytesofman mentioned this in D17315: [Cashtab] Also copy explorer in Dockerfile.Sun, Dec 8, 01:22

bytesofman mentioned this in rABC5a2dab6f2181: [Cashtab] Also copy explorer in Dockerfile.Sun, Dec 8, 02:25