[Cashtab] Reduce tx history rendering
ClosedPublic
Actions

Authored by bytesofman on Sat, Dec 7, 07:12.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCd8fa698a801b: [Cashtab] Reduce tx history rendering

Summary

Sync methods used to parse tx history are causing slow load times due to newly introduced methods to parse agora txs.

This is not the "right" solution. However there are many parts to the right solution and it could take some time to get into prod.

For now, reduce the number of displayed txs to improve performance while working on the right solution.

Test Plan

npm test

this is live at https://cashtab-local-dev.netlify.app/#/

it does not really solve the problem. It does noticeably speed up load times for wallets with agora txs in history, tho need to wait for the wallet to load tx history from chronik to get 10 instead of the 20 that will be cached. The speed issue comes from processing the 20 -- we need to cache them better, load and parse async.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Sat, Dec 7, 07:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Dec 7, 07:12

bytesofman edited the test plan for this revision. (Show Details)Sat, Dec 7, 07:17

Harbormaster completed remote builds in B31565: Diff 51458.Sat, Dec 7, 07:19

bytesofman published this revision for review.Sat, Dec 7, 07:19

bytesofman added a child revision: D17310: [Cashtab] Convert TxHistory.js to ts.Sat, Dec 7, 07:23

There's a 3 second lag to scrolling on this test site. Unlikely to be caused by this diff and I guess we haven't had a diff that necessitated the scrolling of tx history but it is a material issue.

This revision is now accepted and ready to land.Sat, Dec 7, 22:59

Closed by commit rABCd8fa698a801b: [Cashtab] Reduce tx history rendering (authored by bytesofman). · Explain WhySun, Dec 8, 02:35

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd8fa698a801b: [Cashtab] Reduce tx history rendering.