As prep for refactoring for speed
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC2c10d5fb3e97: [Cashtab] Convert Tx screen and its deps to typescript
npm test
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Tail of the build log:
To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-lib@1.1.0 build > tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist Installing ecash-agora dependencies... /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 364 packages, and audited 367 packages in 2s 60 packages are looking for funding run `npm fund` for details 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.2.0 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. added 1489 packages, and audited 3335 packages in 24s 323 packages are looking for funding run `npm fund` for details 6 vulnerabilities (4 moderate, 2 high) To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@3.2.10 build > node scripts/build.js Creating an optimized production build... Failed to compile. TS2305: Module '"ecash-lib"' has no exported member 'AddressType'. [0m [90m 103 |[39m [36mimport[39m appConfig [36mfrom[39m [32m'config/app'[39m[33m;[39m [90m 104 |[39m [36mimport[39m { scriptOps } [36mfrom[39m [32m'ecash-agora'[39m[33m;[39m [31m[1m>[22m[39m[90m 105 |[39m [36mimport[39m { [33mScript[39m[33m,[39m fromHex[33m,[39m [33mOP_0[39m[33m,[39m [33mAddressType[39m } [36mfrom[39m [32m'ecash-lib'[39m[33m;[39m [90m |[39m [31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m [90m 106 |[39m [36mimport[39m [33mCashtabState[39m[33m,[39m { [33mCashtabContact[39m } [36mfrom[39m [32m'config/CashtabState'[39m[33m;[39m [90m 107 |[39m [36mimport[39m [33mCashtabCache[39m [36mfrom[39m [32m'config/CashtabCache'[39m[33m;[39m [90m 108 |[39m [36mimport[39m { [33mCashtabCacheJson[39m[33m,[39m [33mStoredCashtabWallet[39m } [36mfrom[39m [32m'helpers'[39m[33m;[39m[0m Build cashtab-tests failed with exit code 1
cashtab/src/components/Home/Tx/index.tsx | ||
---|---|---|
111 ↗ | (On Diff #51486) | this does seem right. I don't know if it's eslint or prettier but the stack of "always start types with man | with a leading | " is coming from one of them. I don't have a strong enough opinion about it to overrule the linter. |
131 ↗ | (On Diff #51486) | same |
801 ↗ | (On Diff #51486) | here is another fix that is not directly related to ts but indicative of why we need ts in cashtab ts caught this typo bug. |
1170 ↗ | (On Diff #51486) | this artifact was not being used bc there is no style prop accepted by the CopyIconButton component. Typescript picked up on this. So, here we are removing dead code picked up by ts (and ts linter will fail if we leave it in, so it needs to come out). It probably used to work before the CopyIconButton was moved out of antd. Can confirm by checking this component in prod dev console. There is no set z-index. |
cashtab/src/components/Home/TxHistory.tsx | ||
22 ↗ | (On Diff #51486) | ditto as above, this is (strangely mb) the linter/formatter rule |