Differential D17322

[guix] Fix errors for macos build from the jsonrpc dependencies
ClosedPublic
Actions

Authored by Fabien on Mon, Dec 9, 14:09.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe925881de375: [guix] Fix errors for macos build from the jsonrpc dependencies

Summary

Several changes are needed to accomodate the aws-lc-sys library which is a dependency for the jsonrpc server over tls.

If linking is needed then lld needs to be used.
The CoreFundation framework needs to be linked
We can't use the cmake build for aws-lc-sys because it expects an install-name-tool that we don't have

Test Plan

Run the macos guix build

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Dec 9, 14:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 9, 14:09

Fabien requested review of this revision.Mon, Dec 9, 14:09

@bot guix-osx

teamcity awarded a token.Mon, Dec 9, 14:11

PiRK accepted this revision.Mon, Dec 9, 14:48

This revision is now accepted and ready to land.Mon, Dec 9, 14:48

Harbormaster completed remote builds in B31585: Diff 51495.Mon, Dec 9, 14:59

Closed by commit rABCe925881de375: [guix] Fix errors for macos build from the jsonrpc dependencies (authored by Fabien). · Explain WhyMon, Dec 9, 15:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe925881de375: [guix] Fix errors for macos build from the jsonrpc dependencies.

Revision Contents
Changeset List

Path

Size

chronik/

CMakeLists.txt

9 lines

contrib/

guix/

libexec/

build.sh

12 lines

Diff 51498

View Options

chronik/CMakeLists.txt