Page MenuHomePhabricator
Differential D17344

[e.cash] Add Pay2Stay to Use eCash page
ClosedPublic
Actions

Authored by Mengerian on Thu, Dec 12, 21:31.

Details

Reviewers
Kronkmeister
Group Reviewers
Restricted Project
Commits
rABC0ff417889439: [e.cash] Add Pay2Stay to Use eCash page
Summary

Pay2Stay are launching and promoting themselves, so good time to add them to the site.

Test Plan

Ran it locally, checked the link.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mengerian created this revision.Thu, Dec 12, 21:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Dec 12, 21:31
Mengerian requested review of this revision.Thu, Dec 12, 21:31
Harbormaster completed remote builds in B31632: Diff 51562.Thu, Dec 12, 21:31
Fabien added a subscriber: Fabien.Thu, Dec 12, 21:41

@bot preview-e.cash

teamcity awarded a token.Thu, Dec 12, 21:41

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41084 for the next 60 minutes.

Fabien added a comment.Thu, Dec 12, 21:47

Any reason for the selected ordering ? Poker first then pay2stay then paybutton ?

web/e.cash/pages/use-ecash.js
169 ↗(On Diff #51562)

This should open in a new tab

Kronkmeister accepted this revision.Thu, Dec 12, 21:48
Kronkmeister added a subscriber: Kronkmeister.

tested and approved 💪

This revision is now accepted and ready to land.Thu, Dec 12, 21:48
Mengerian added a subscriber: johnkuney.Thu, Dec 12, 21:54
In D17344#394125, @Fabien wrote:

Any reason for the selected ordering ?

No reason, just randomly put it there.
Happy to change the order if you think another order is better

web/e.cash/pages/use-ecash.js
169 ↗(On Diff #51562)

I asked @johnkuney to fix this, can be done in another Diff

Fabien added inline comments.Thu, Dec 12, 21:58
web/e.cash/pages/use-ecash.js
147 ↗(On Diff #51562)

This is what you need

Mengerian updated this revision to Diff 51563.Thu, Dec 12, 22:03

Open link in new tab
Change order

Harbormaster completed remote builds in B31633: Diff 51563.Thu, Dec 12, 22:03
Closed by commit rABC0ff417889439: [e.cash] Add Pay2Stay to Use eCash page (authored by Mengerian). · Explain WhyThu, Dec 12, 22:08
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC0ff417889439: [e.cash] Add Pay2Stay to Use eCash page.

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
28 lines
public/
images/

Diff 51565

View Options

web/e.cash/pages/use-ecash.js

Loading...
View Options

web/e.cash/public/images/Pay2Stay.png

Loading...