Page MenuHomePhabricator
Differential D17358

[ecash-herald] patch docker
ClosedPublic
Actions

Authored by bytesofman on Mon, Dec 16, 04:50.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC9c49d22f48d3: [ecash-herald] patch docker
Summary

fix capitalization mismatch

in fixing the lint error thrown on WasmBuilder, did not update all instances of it

for some reason ... builds do not fail in this case. tho the app won't work.

Test Plan

docker build -f ecash-herald.Dockerfile -t ecash-herald_local .

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-docker-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31671
Build 62838: Build Diff
Build 62837: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mon, Dec 16, 04:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 16, 04:50
Harbormaster completed remote builds in B31671: Diff 51610.Mon, Dec 16, 04:50
bytesofman published this revision for review.Mon, Dec 16, 04:53
bytesofman edited the summary of this revision. (Show Details)
PiRK accepted this revision.Mon, Dec 16, 06:09
This revision is now accepted and ready to land.Mon, Dec 16, 06:09
Closed by commit rABC9c49d22f48d3: [ecash-herald] patch docker (authored by bytesofman). · Explain WhyMon, Dec 16, 13:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC9c49d22f48d3: [ecash-herald] patch docker.

Revision Contents
Changeset List

Diff 51610

View Options

ecash-herald.Dockerfile

Loading...