Page MenuHomePhabricator

[Cashtab] Use user modal confirmation settings for minting tokens
AcceptedPublic

Authored by bytesofman on Sat, Dec 21, 23:52.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

T3709

Currently there is no confirmation on mint txs.

imo Mint is not the kind of action that always needs a confirmation (like burn). So, defer to user settings on this.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mint-confirm
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31738
Build 62970: Build Diffcashtab-tests
Build 62969: arc lint + arc unit

Event Timeline

emack added a subscriber: emack.
emack added inline comments.
cashtab/src/components/Etokens/__tests__/Token.test.js
967

how do you simulate this environment var in int tests?

This revision is now accepted and ready to land.Sun, Dec 22, 09:45