Differential D17399
[Cashtab] Remove legacy aliases implementation Authored by bytesofman on Thu, Dec 26, 17:41.
Details
chronik and Cashtab dev have progressed beyond this implementation approach. When aliases go into prod, they will not be implemented in this way -- instead we will use a chronik plugin. Remove legacy alias implementation code from Cashtab. Keeping this code up to date with other Cashtab improvements is not worth the effort. npm test
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log: run `npm fund` for details 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-lib@1.2.0 build > tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist Installing ecash-agora dependencies... /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 364 packages, and audited 367 packages in 1s 60 packages are looking for funding run `npm fund` for details 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.2.0 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. added 1488 packages, and audited 3309 packages in 24s 320 packages are looking for funding run `npm fund` for details 8 vulnerabilities (6 moderate, 2 high) To address issues that do not require attention, run: npm audit fix To address all issues (including breaking changes), run: npm audit fix --force Run `npm audit` for details. > cashtab@3.4.5 build > node scripts/build.js Creating an optimized production build... Failed to compile. Module not found: Error: Can't resolve 'config/alias' in '/work/cashtab/src/validation' Build cashtab-tests failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log: 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.2.0 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. added 1488 packages, and audited 3309 packages in 24s 320 packages are looking for funding run `npm fund` for details 8 vulnerabilities (6 moderate, 2 high) To address issues that do not require attention, run: npm audit fix To address all issues (including breaking changes), run: npm audit fix --force Run `npm audit` for details. > cashtab@3.4.5 build > node scripts/build.js Creating an optimized production build... Treating warnings as errors because process.env.CI = true. Most CI servers set it automatically. Failed to compile. [eslint] src/components/App/App.js Line 16:5: 'ThemedUserProfileIcon' is defined but never used @typescript-eslint/no-unused-vars src/components/Etokens/Token/index.tsx Line 13:10: 'TxLink' is defined but never used @typescript-eslint/no-unused-vars src/components/Send/SendXec.tsx Line 34:5: 'TxLink' is defined but never used @typescript-eslint/no-unused-vars Line 849:15: 'address' is assigned a value but never used @typescript-eslint/no-unused-vars src/opreturn/index.ts Line 5:29: 'decodeCashAddress' is defined but never used @typescript-eslint/no-unused-vars Line 13:5: 'OP_0' is defined but never used @typescript-eslint/no-unused-vars src/wallet/useWallet.ts Line 44:5: 'CashtabPathInfo' is defined but never used @typescript-eslint/no-unused-vars Build cashtab-tests failed with exit code 1 Comment Actions imo this also needs to go. I do not think we should implement aliases if it is not on a spec that a chronik plugin can index. I could remove it in this diff as well. Was planning to do it separately as it has its own CI-related impacts. |