Part of ongoing incremental upgrade of Cashtab to typescript
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCa3cb3bd23735: [Cashtab] Convert BackupWallet screen to ts
npm test, ts lint runs in CI
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| cashtab/src/components/BackupWallet/BackupWallet.tsx | ||
|---|---|---|
| 61 ↗ | (On Diff #51750) | I guess you always have a wallet if you're loading the backup screen ? |
| cashtab/src/components/BackupWallet/BackupWallet.tsx | ||
|---|---|---|
| 61 ↗ | (On Diff #51750) | this matches the implementation we use on all the components converted to typescript The App screen only renders <Onboarding/> component if we do not have a valid wallets[0] So we can get rid of this check. Typescript is what lets us know this is true now. The check against false is an artifact from the dev era before Cashtab had a wallet type and any screen could load for a user with no wallet. |