[Cashtab] Convert BackupWallet screen to ts
ClosedPublic
Actions

Authored by bytesofman on Dec 26 2024, 18:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

Part of ongoing incremental upgrade of Cashtab to typescript

Test Plan

npm test, ts lint runs in CI

Repository

rABC Bitcoin ABC

Branch

backup-wallet-to-ts

Lint

Lint Passed

Unit

No Test Coverage

Build Status

bytesofman published this revision for review.Dec 26 2024, 18:21

Fabien added inline comments.

cashtab/src/components/BackupWallet/BackupWallet.tsx
61	I guess you always have a wallet if you're loading the backup screen ?

bytesofman marked an inline comment as done.Dec 26 2024, 22:18

bytesofman added inline comments.

cashtab/src/components/BackupWallet/BackupWallet.tsx
61	this matches the implementation we use on all the components converted to typescript The `App` screen only renders `<Onboarding/>` component if we do not have a valid `wallets[0]` So we can get rid of this check. Typescript is what lets us know this is true now. The check against `false` is an artifact from the dev era before Cashtab had a wallet type and any screen could load for a user with no wallet.