Page MenuHomePhabricator

[Cashtab] Convert App screen and deps to ts
ClosedPublic

Authored by bytesofman on Thu, Dec 26, 23:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCedca57c3683c: [Cashtab] Convert App screen and deps to ts
Summary

Convert App screen to ts. Some deps need to be updated as well to avoid lint errors.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
app-to-ts
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31779
Build 63051: Build Diffcashtab-tests
Build 63050: arc lint + arc unit

Event Timeline

Tail of the build log:

> ecash-lib@1.2.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1488 packages, and audited 3309 packages in 25s

320 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (6 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.4.6 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2786: 'ServiceWorkerWrapper' cannot be used as a JSX component.
  Its return type 'false | Element' is not a valid JSX element.
    Type 'boolean' is not assignable to type 'ReactElement<any, any>'.
    119 |             ) : (
    120 |                 <>
  > 121 |                     <ServiceWorkerWrapper />
        |                      ^^^^^^^^^^^^^^^^^^^^
    122 |                     <WebApp />
    123 |                 </>
    124 |             )}


Build cashtab-tests failed with exit code 1

convert more deps to fix tslint

This revision is now accepted and ready to land.Fri, Dec 27, 15:32