Page MenuHomePhabricator

[Cashtab + doc] Parse XECX rewards
Needs RevisionPublic

Authored by bytesofman on Fri, Dec 27, 12:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Add spec for XECX EMPP txs

Implement spec in Cashtab to parse XECX payout txs

To do this, we implement parsing EMPP app actions in Cashtab with associated helper functions.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
xecx-doc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31783
Build 63059: Build Diffcashtab-tests
Build 63058: arc lint + arc unit

Event Timeline

test error cases for getEmppActions

Fabien requested changes to this revision.Sat, Dec 28, 20:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/chronik/index.ts
493 ↗(On Diff #51770)

concat ? Also why do you do a copy here ?

I would expect a push in a loop intuitively.

cashtab/src/opreturn/index.ts
292 ↗(On Diff #51770)

no consume ? I remember we added a consume function at some point

302 ↗(On Diff #51770)

should it be an error if it is undefined ?

330 ↗(On Diff #51770)

Any plan to move the agora parsing here ?

doc/standards/op_return-prefix-guideline.md
27 ↗(On Diff #51770)

You should create a separated spec file and reference it in the array. It's now big enough that it's not really readable

This revision now requires changes to proceed.Sat, Dec 28, 20:59