Page MenuHomePhabricator

[Cashtab] Sort OrderBook by price and then min buy amounts
ClosedPublic

Authored by bytesofman on Sun, Dec 29, 15:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbf75fc6957c4: [Cashtab] Sort OrderBook by price and then min buy amounts
Summary

Some listings e.g. XECX have different listings at the same price. In this case, the sort is random.

Apply a second dimension sort of the min buy amount to distinguish between these listings.

Test Plan

npm test, I did not add a specific test for this sort bc it is basically a JS primitive, can visit test site and see XECX listing page

deployed here

https://cashtab-local-dev.netlify.app/#/token/c67bf5c2b6d91cfb46a5c1772582eff80d88686887be10aa63b0945479cf4ed4

Diff Detail

Repository
rABC Bitcoin ABC
Branch
orderbook-second-sort
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31809
Build 63111: Build Diffcashtab-tests
Build 63110: arc lint + arc unit