Paths

Table of Contentst

Differential D17420

[Cashtab] Use locale formatted numbers for agora offer previews
ClosedPublic
Actions

Authored by bytesofman on Sun, Dec 29, 17:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6b6b7f47b6fb: [Cashtab] Use locale formatted numbers for agora offer previews

Summary

For large token values, it is difficult to read without locale thousands separators. Use already-available function to add them.

Test Plan

npm test, npm start and view large offer to confirm. The function itself is already tested and should have been implemented here originally.

before:

after:

Diff Detail

Repository

rABC Bitcoin ABC

Branch

better-num-methods-agora

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31810
Build 63113: Build Diff	cashtab-tests
Build 63112: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sun, Dec 29, 17:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Dec 29, 17:55

bytesofman edited the test plan for this revision. (Show Details)Sun, Dec 29, 17:57

Harbormaster completed remote builds in B31810: Diff 51815.Sun, Dec 29, 17:59

bytesofman published this revision for review.Sun, Dec 29, 18:04

Fabien accepted this revision.Sun, Dec 29, 19:24

This revision is now accepted and ready to land.Sun, Dec 29, 19:24

Closed by commit rABC6b6b7f47b6fb: [Cashtab] Use locale formatted numbers for agora offer previews (authored by bytesofman). · Explain WhySun, Dec 29, 19:28

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC6b6b7f47b6fb: [Cashtab] Use locale formatted numbers for agora offer previews.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Etokens/

Token/

index.tsx

26 lines

Diff 51815

View Options

cashtab/src/components/Etokens/Token/index.tsx

[Cashtab] Use locale formatted numbers for agora offer previewsClosedPublicActions