Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot
Changes PlannedPublic
Actions

Authored by PiRK on Tue, Dec 31, 10:50.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot

https://github.com/bitcoin/bitcoin/pull/27746/commits/272fbc370c4e133d31d9f1d34e327cc265c5fad2

test: Clear block index flags when testing snapshots

When simulating a snapshot, remove the HAVE_DATA status for blocks below the
snapshot height, to simulate never having downloaded them at all. This makes
tests more realistic (and more closely match what will happen when using
assumeutxo).

https://github.com/bitcoin/bitcoin/pull/27746/commits/3cfc75366e6596942cbc84f354f42dfd7fc5c073

This is a partial backport of core#27746

Depends on D17433

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31849
Build 63190: Build Diff	build-debug · build-clang-tidy · build-without-wallet · build-diff · lint-circular-dependencies · build-clang
Build 63189: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, Dec 31, 10:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 31, 10:50

PiRK requested review of this revision.Tue, Dec 31, 10:50

teamcity edited the summary of this revision. (Show Details)Tue, Dec 31, 10:51

PiRK edited the summary of this revision. (Show Details)Tue, Dec 31, 10:51

PiRK added a parent revision: D17433: Move block-arrival information / preciousblock counters to ChainstateManager.

Harbormaster completed remote builds in B31849: Diff 51869.Tue, Dec 31, 11:01

I have a test failing in a later commit due to an assertion in validation.cpp on line 6093 (Assertion pindex->nStatus.isOnParkedChain() || setBlockIndexCandidates.count(pindex)' failed..) I need to check if I missed something here, or if the issue is introduced later.