[Cashtab] Add tooltipped icon on Agora Offers created by the token creator
ClosedPublic
Actions

Authored by bytesofman on Tue, Dec 31, 14:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC064ad0851df0: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator

Summary

Useful visual reference to distinguish sell offers from the tokens mint address vs other sell offers.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Tue, Dec 31, 14:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 31, 14:25

Harbormaster completed remote builds in B31850: Diff 51870.Tue, Dec 31, 14:30

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: <Agora /> We can see multiple offers, some we made, others we did not, and we can cancel an offer ======
Error: expect(received).toBeInTheDocument()

received value must be an HTMLElement or an SVGElement.
Received has value: undefined
    at __EXTERNAL_MATCHER_TRAP__ (/work/cashtab/node_modules/expect/build/index.js:325:30)
    at Object.throwingMatcher [as toBeInTheDocument] (/work/cashtab/node_modules/expect/build/index.js:326:15)
    at Object.toBeInTheDocument (/work/cashtab/src/components/Agora/__tests__/index.test.js:647:11)

Each failure log is accessible here:
CashTab Unit Tests: <Agora /> We can see multiple offers, some we made, others we did not, and we can cancel an offer

confirm with test

bytesofman edited the test plan for this revision. (Show Details)Tue, Dec 31, 14:34

Harbormaster completed remote builds in B31851: Diff 51871.Tue, Dec 31, 14:39

bytesofman published this revision for review.Tue, Dec 31, 14:40

remove unused mock rawtx from new test

Harbormaster completed remote builds in B31852: Diff 51872.Tue, Dec 31, 14:47

I thought about that but you can't really know if it's the creator, right ? I mean the creator can have several addresses

In D17441#396586, @Fabien wrote:

I thought about that but you can't really know if it's the creator, right ? I mean the creator can have several addresses

it's possible we could have "creator-made" offers that we miss with this check

but we know that every offer that does match this check is creator-made

in practice, all user facing apps for token minting now will make a genesis tx that passes this check.

So, I think it's worth adding. It's not really a "legitimacy" check so much as useful info.

Fabien accepted this revision.Tue, Dec 31, 16:38

This revision is now accepted and ready to land.Tue, Dec 31, 16:38

Closed by commit rABC064ad0851df0: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator (authored by bytesofman). · Explain WhyTue, Dec 31, 16:47

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC064ad0851df0: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator.