Page MenuHomePhabricator
Differential D17456

[cashtab] Fix the unit tests verbosity
ClosedPublic
Actions

Authored by Fabien on Thu, Jan 2, 14:57.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC58f250b0e5a4: [cashtab] Fix the unit tests verbosity
Summary

Don't print to the console unless there is actually a test failure. The current unit test output is unusable because it's bloated with expected failures that we don't need/want to see.

Test Plan

Be prepared, you could get shocked:

npm run test

Add a deliberate test failure and check it still pops up.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab_fix_tests_verbose
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31888
Build 63268: Build Diffcashtab-tests
Build 63267: arc lint + arc unit

Event Timeline

Fabien created this revision.Thu, Jan 2, 14:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 2, 14:57
Fabien requested review of this revision.Thu, Jan 2, 14:57
bytesofman accepted this revision.Thu, Jan 2, 15:00
bytesofman added a subscriber: bytesofman.

finally lmao

This revision is now accepted and ready to land.Thu, Jan 2, 15:00
Harbormaster completed remote builds in B31888: Diff 51918.Thu, Jan 2, 15:03
Closed by commit rABC58f250b0e5a4: [cashtab] Fix the unit tests verbosity (authored by Fabien). · Explain WhyThu, Jan 2, 15:10
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC58f250b0e5a4: [cashtab] Fix the unit tests verbosity.

Revision Contents
Changeset List

PathSize
cashtab/
scripts/
2 lines

Diff 51918

View Options

cashtab/scripts/test.js

Loading...