Differential D17476

[explorer] Show as much token tx information as possible when the genesis info is missing
ClosedPublic
Actions

Authored by Fabien on Jan 6 2025, 19:40.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3ec850ae770c: [explorer] Show as much token tx information as possible when the genesis info…

Summary

Since D17470 the explorer don't fail to show a transaction with a non-existing token id. But it also display not much information on the tx page due to missing the genesis info. This diff improves the page under this condition so it shows at least the token type and the error.

Depends on D17470.

Test Plan

cargo run

Open http://localhost:3035/tx/9f938f1c670fbcee7980c53d7b5a059ab64f5c93dc8290a8d10068b6dd696316

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 6 2025, 19:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2025, 19:40

Fabien requested review of this revision.Jan 6 2025, 19:40

Harbormaster completed remote builds in B31943: Diff 51989.Jan 6 2025, 19:44

Build Bitcoin ABC Diffs / Diff Testing (build-explorer) failed.

Tail of the build log:

---- test_tx stdout ----
Error: HTTP request error

Caused by:
   0: error sending request for url (https://chronik.e.cash/tx/f4184fc596403b9d638783cf57adfe4c75c605f6356fbc91338530e9831e9e16): error trying to connect: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889: (certificate has expired)
   1: error trying to connect: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889: (certificate has expired)
   2: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889: (certificate has expired)
   3: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889:

Location:
    /work/modules/bitcoinsuite-chronik-client/src/lib.rs:257:14

---- test_slpv2_token stdout ----
Error: HTTP request error

Caused by:
   0: error sending request for url (https://chronik.e.cash/token/cdcdcdcdcdc9dda4c92bb1145aa84945c024346ea66fd4b699e344e45df2e145): error trying to connect: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889: (certificate has expired)
   1: error trying to connect: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889: (certificate has expired)
   2: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889: (certificate has expired)
   3: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889:

Location:
    /work/modules/bitcoinsuite-chronik-client/src/lib.rs:257:14

---- test_tx_missing stdout ----
thread 'test_tx_missing' panicked at modules/bitcoinsuite-chronik-client/tests/test_chronik_client.rs:129:5:
assertion failed: `(left == right)`

[1mDiff[0m [31m< left[0m / [32mright >[0m :
[31m<HttpRequestError[0m
[32m>ChronikError {[0m
[32m>    status_code: 404,[0m
[32m>    error: Error {[0m
[32m>        msg: "404: Transaction 0000000000000000000000000000000000000000000000000000000000000000 not found in the index",[0m
[32m>    },[0m
[32m>    error_msg: "404: Transaction 0000000000000000000000000000000000000000000000000000000000000000 not found in the index",[0m
[32m>}[0m




failures:
    test_block
    test_block_txs
    test_blockchain_info
    test_blocks
    test_broadcast_tx
    test_broadcast_txs
    test_history
    test_raw_tx
    test_raw_tx_missing
    test_slpv1_token
    test_slpv2_token
    test_tx
    test_tx_missing

test result: FAILED. 0 passed; 13 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.19s

error: test failed, to rerun pass `-p bitcoinsuite-chronik-client --test test_chronik_client`
Build build-explorer failed with exit code 101

@bot build-explorer

teamcity awarded a token.Jan 7 2025, 07:46

PiRK accepted this revision.Jan 7 2025, 08:55

This revision is now accepted and ready to land.Jan 7 2025, 08:55

Closed by commit rABC3ec850ae770c: [explorer] Show as much token tx information as possible when the genesis info… (authored by Fabien). · Explain WhyJan 7 2025, 13:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3ec850ae770c: [explorer] Show as much token tx information as possible when the genesis info….