We may add more plugins at some point, let's not get limited by the name.
Depends on D17492.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC8592b9457a71: Rename chronik-agora to chronik-plugins
\o/
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- rename_dir_chronik_plugins
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31977 Build 63446: Build Diff Build 63445: arc lint + arc unit
Event Timeline
| contrib/docker/chronik-plugins/copy_plugin_files.sh | ||
|---|---|---|
| 27 | should this be an arg now? or alt, should this file be renamed copy_agora_files.sh? now that this is a general plugin dir, seems like the behavior of this file (only working for agora) is not lined up with the org strategy. we should either have one file that takes an arg or a file for each plugin. | |
| contrib/docker/chronik-plugins/copy_plugin_files.sh | ||
|---|---|---|
| 27 | Not really, it's just that we only have agora as a plugin for now. If one day we add e.g. an alias plugin, then we can add it to the same file and have it be part of the image. | |
| contrib/docker/chronik-plugins/copy_plugin_files.sh | ||
|---|---|---|
| 27 | oh right. forgot that the plugins are not either/or, and ultimately yes we will want servers that have them all or have flags for setting only some. | |