[chronik] cleanup of json_to_u31 helper function
ClosedPublic
Actions

Authored by PiRK on Fri, Jan 10, 12:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf3dfa6c485fe: [chronik] cleanup of json_to_u31 helper function

Summary

This makes the code more idiomatic, saves a string conversion (in the success case) and two clones in all cases.

Depends on D17501

Test Plan

nija check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, Jan 10, 12:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jan 10, 12:17

PiRK requested review of this revision.Fri, Jan 10, 12:17

Harbormaster completed remote builds in B32030: Diff 52109.Fri, Jan 10, 12:41

Unknown Object (User) added a subscriber: Unknown Object (User).Fri, Jan 10, 12:42

This comment was removed by Fabien.

Fabien added a subscriber: Fabien.Fri, Jan 10, 12:52

Fabien accepted this revision.Fri, Jan 10, 12:56

Fabien added inline comments.

chronik/chronik-http/src/electrum.rs
340 ↗	(On Diff #52109)	TIL

This revision is now accepted and ready to land.Fri, Jan 10, 12:56

Closed by commit rABCf3dfa6c485fe: [chronik] cleanup of json_to_u31 helper function (authored by PiRK). · Explain WhyFri, Jan 10, 14:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf3dfa6c485fe: [chronik] cleanup of json_to_u31 helper function.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-http/

src/

electrum.rs

18 lines

Diff 52114

View Options

chronik/chronik-http/src/electrum.rs

[chronik] cleanup of json_to_u31 helper functionClosedPublicActions