Paths

Table of Contentst

Differential D17520

[Cashtab] Use locale thousands separators for large prices
ClosedPublic
Actions

Authored by bytesofman on Sun, Jan 12, 18:36.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCb9ab1dec1748: [Cashtab] Use locale thousands separators for large prices

Summary

1,000,000 (or other locale separators) much more user friendly than 1000000

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

better-locale-formatting-agora

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32061
Build 63614: Build Diff	cashtab-tests
Build 63613: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sun, Jan 12, 18:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jan 12, 18:36

Harbormaster completed remote builds in B32061: Diff 52155.Sun, Jan 12, 18:41

bytesofman published this revision for review.Sun, Jan 12, 19:18

PiRK accepted this revision.Mon, Jan 13, 08:01

This revision is now accepted and ready to land.Mon, Jan 13, 08:01

Closed by commit rABCb9ab1dec1748: [Cashtab] Use locale thousands separators for large prices (authored by bytesofman). · Explain WhyMon, Jan 13, 12:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCb9ab1dec1748: [Cashtab] Use locale thousands separators for large prices.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

formatting/

fixtures/

vectors.js

7 lines

index.ts

11 lines

Diff 52155

View Options

cashtab/src/formatting/fixtures/vectors.js