[test] Fix intermittent timeouts in various functional tests
ClosedPublic
Actions

Authored by roqqit on Wed, Jan 15, 00:11.

Details

Reviewers

Fabien
PiRK

Group Reviewers

Restricted Project

Commits

rABC18aa9533dcc9: [test] Fix intermittent timeouts in various functional tests

Summary

Original PR message was "test: Fix intermittent timeout in p2p_permissions.py" but the impact is larger than this, notably rpc_net.py.

Pull request description:

The sync is based on `bytesrecv_per_msg["verack"]`. However, the bytes are counted before processing the message, so they are not sufficient to ensure the connection is fully up.

Backport of core#26854

Depends on D17530

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

roqqit created this revision.Wed, Jan 15, 00:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 15, 00:11

roqqit requested review of this revision.Wed, Jan 15, 00:11

teamcity edited the summary of this revision. (Show Details)Wed, Jan 15, 00:11

Harbormaster completed remote builds in B32091: Diff 52198.Wed, Jan 15, 00:28

Fabien accepted this revision.Wed, Jan 15, 09:20

This revision is now accepted and ready to land.Wed, Jan 15, 09:20

PiRK accepted this revision.Wed, Jan 15, 09:21

Closed by commit rABC18aa9533dcc9: [test] Fix intermittent timeouts in various functional tests (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by roqqit). · Explain WhyWed, Jan 15, 22:25

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC18aa9533dcc9: [test] Fix intermittent timeouts in various functional tests.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

16 lines

Diff 52229

View Options

test/functional/test_framework/test_framework.py

[test] Fix intermittent timeouts in various functional testsClosedPublicActions