Differential D17543

[mock-chronik-client] Clean up test mocks file
ClosedPublic
Actions

Authored by bytesofman on Jan 16 2025, 05:26.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC36524d889f0e: [mock-chronik-client] Clean up test mocks file

Summary

The mocks are somewhat generated but the file should still be reviewed.

Any changes to tests should have typed mocks that match new tests
We had garbage and lint issues in this file that was missed from the generated tag

Test Plan

proofread, CI tests still pass

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 16 2025, 05:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2025, 05:26

bytesofman published this revision for review.Jan 16 2025, 05:27

Harbormaster completed remote builds in B32119: Diff 52233.Jan 16 2025, 05:32

PiRK accepted this revision.Jan 16 2025, 07:37

This revision is now accepted and ready to land.Jan 16 2025, 07:37

Closed by commit rABC36524d889f0e: [mock-chronik-client] Clean up test mocks file (authored by bytesofman). · Explain WhyJan 16 2025, 13:22

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC36524d889f0e: [mock-chronik-client] Clean up test mocks file.

Revision Contents
Changeset List

Path

Size

modules/

mock-chronik-client/

mocks/

index.ts

628 lines

Diff 52236

View Options

modules/mock-chronik-client/mocks/index.ts

[mock-chronik-client] Clean up test mocks fileClosedPublicActions