Differential D17543

[mock-chronik-client] Clean up test mocks file
ClosedPublic
Actions

Authored by bytesofman on Thu, Jan 16, 05:26.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC36524d889f0e: [mock-chronik-client] Clean up test mocks file

Summary

The mocks are somewhat generated but the file should still be reviewed.

Any changes to tests should have typed mocks that match new tests
We had garbage and lint issues in this file that was missed from the generated tag

Test Plan

proofread, CI tests still pass

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mcc-cleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32119
Build 63729: Build Diff	mock-chronik-client-tests · token-server-tests · ecash-herald-tests · cashtab-tests
Build 63728: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Jan 16, 05:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 16, 05:26

bytesofman published this revision for review.Thu, Jan 16, 05:27

Harbormaster completed remote builds in B32119: Diff 52233.Thu, Jan 16, 05:32

PiRK accepted this revision.Thu, Jan 16, 07:37

This revision is now accepted and ready to land.Thu, Jan 16, 07:37

Closed by commit rABC36524d889f0e: [mock-chronik-client] Clean up test mocks file (authored by bytesofman). · Explain WhyThu, Jan 16, 13:22

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC36524d889f0e: [mock-chronik-client] Clean up test mocks file.

Revision Contents
Changeset List

Path

Size

modules/

mock-chronik-client/

mocks/

index.ts

628 lines

Diff 52233

View Options

modules/mock-chronik-client/mocks/index.ts

[mock-chronik-client] Clean up test mocks fileClosedPublicActions