Page MenuHomePhabricator
Differential D17546

[electrum] Fix the homescreen change with all devices
ClosedPublic
Actions

Authored by Fabien on Thu, Jan 16, 15:36.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC2c1219ed56c6: [electrum] Fix the homescreen change with all devices
Summary

The Safe 3 requires to handle the TOIG format so it's explicitely not supported for now. New devices should be supported automatically with this code change.

Test Plan

Change the homescreen for all devices.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
electrum_homescreen
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32128
Build 63747: Build Diffelectrum-tests
Build 63746: arc lint + arc unit

Event Timeline

Fabien created this revision.Thu, Jan 16, 15:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 16, 15:36
Fabien requested review of this revision.Thu, Jan 16, 15:36
Harbormaster completed remote builds in B32127: Diff 52245.Thu, Jan 16, 15:38
Fabien updated this revision to Diff 52246.Thu, Jan 16, 15:41

Less code duplication

Harbormaster completed remote builds in B32128: Diff 52246.Thu, Jan 16, 15:43
PiRK accepted this revision.Thu, Jan 16, 17:08
PiRK added a subscriber: PiRK.
PiRK added inline comments.
electrum/electrumabc_plugins/trezor/qt.py
553
This revision is now accepted and ready to land.Thu, Jan 16, 17:08
Closed by commit rABC2c1219ed56c6: [electrum] Fix the homescreen change with all devices (authored by Fabien). · Explain WhyThu, Jan 16, 20:02
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC2c1219ed56c6: [electrum] Fix the homescreen change with all devices.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_plugins/
trezor/
197 lines

Diff 52246

View Options

electrum/electrumabc_plugins/trezor/qt.py

Loading...