Differential D17561

=2.4.0
ClosedPublic
Actions

Authored by PiRK on Sat, Jan 18, 09:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdf23154ef489: [electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other…

Summary

Without this fix, users who set a pin longer than 9 digits will not be able to pair their device with Electrum ABC.

https://github.com/spesmilo/electrum/commit/be0ef5f961e5dcc7be2394728679674cdf81fb5d
https://github.com/spesmilo/electrum/commit/44f83b78e2530a2952adffcd388e6a162976278b
https://github.com/spesmilo/electrum/commit/6172898a035e6ccbe5e8c85a34bc2f14acd106b3

Test Plan

With a Trezor 1 device protected with a pin longer than 9 digits, check that prior to this diff you cannot pair with the device and after this diff you can

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sat, Jan 18, 09:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jan 18, 09:17

PiRK requested review of this revision.Sat, Jan 18, 09:17

Note that I had to first revert D17457 to test this, because D17457 introduces a new bug preventing pairing with a Trezor 1

PiRK added inline comments.Sat, Jan 18, 09:21

electrum/electrumabc_plugins/trezor/clientbase.py
337 ↗	(On Diff #52300)	It is probably pointless to test this for other Trezor models, I don't think Trezor T, Safe3 and Safe 5 will ever call this method. Everyting happens on the device, the device does not need to ask for the software to give it input to type the PIN except for Trezor 1. But it doesn't hurt either to test this 2.4.0 version, so lets keep it just to be on the safe side (mayber I'm missing some use case where the device really needs input from the outside world ?)