HomePhabricator

[electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other…

Description

[electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other devices firmware >=2.4.0

Summary:
Without this fix, users who set a pin longer than 9 digits will not be able to pair their device with Electrum ABC.

https://github.com/spesmilo/electrum/commit/be0ef5f961e5dcc7be2394728679674cdf81fb5d
https://github.com/spesmilo/electrum/commit/44f83b78e2530a2952adffcd388e6a162976278b
https://github.com/spesmilo/electrum/commit/6172898a035e6ccbe5e8c85a34bc2f14acd106b3

Test Plan: With a Trezor 1 device protected with a pin longer than 9 digits, check that prior to this diff you cannot pair with the device and after this diff you can

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D17561

Details

Provenance
Sander van Grieken <sander@outrightsolutions.nl>Authored on Jul 7 2023, 10:33
PiRKCommitted on Mon, Jan 20, 07:38
PiRKPushed on Mon, Jan 20, 07:38
Reviewer
Restricted Project
Differential Revision
D17561: [electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other devices firmware >=2.4.0
Parents
rABCa900d0d9cd88: [Automated] Update seeds
Branches
Unknown
Tags
Unknown