[ecash-lib] Add `pbkdf2`
AcceptedPublic
Actions

Authored by tobias_ruck on Thu, Jan 30, 03:56.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

This is used to hash a "seed" from a mnemonic (seed phrase).

Depends on D17609.

Test Plan

npm test

Repository

rABC Bitcoin ABC

Branch

ecash-lib-pbkdf2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32256
Build 64002: Build Diff	ecash-lib-integration-tests · cashtab-tests · ecash-lib-tests · ecash-agora-integration-tests · ecash-agora-tests
Build 64001: arc lint + arc unit

add copyright

tobias_ruck published this revision for review.Thu, Jan 30, 09:43

bytesofman requested changes to this revision.Thu, Jan 30, 18:37

bytesofman added inline comments.

modules/ecash-lib/src/pbkdf2.test.ts
32	this matches the test result in https://github.com/paulmillr/noble-hashes/blob/main/test/kdf.test.js
37	it looks like this does not match the result from https://github.com/paulmillr/noble-hashes/blob/main/test/kdf.test.js is this expected? https://github.com/paulmillr/noble-hashes/blob/main/test/kdf.test.js#L163

This revision now requires changes to proceed.Thu, Jan 30, 18:37

tobias_ruck requested review of this revision.Thu, Jan 30, 22:09

tobias_ruck added inline comments.

modules/ecash-lib/src/pbkdf2.test.ts
37	oh, here I reduced the number of iterations from 80000 to 8000 the test would run for 1200ms otherwise—if that's fine I can bump it, or change it to a iteration count that's not so similar. I suspect the solution here is not as optimized as the the one from noble. Maybe we should move it to Rust entirely (but maybe not now)