[chronik] return empty transaction history for an unknown scripthash
AcceptedPublic
Actions

Authored by PiRK on Thu, Jan 30, 13:02.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

An unknown scripthash may correspond to a valid script that was never seen in the block chain or in the mempool. For consistency with scripts, make the various tx history endpoints return an empty history for unknown scripthashes.

The utxos endpoint is unchanged and keeps returning a 404 error, because if we never saw the scripthash before we cannot know what script it is related to, and we cannot construct the response.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32257
Build 64004: Build Diff	chronik-client-integration-tests · ecash-agora-integration-tests · build-diff · ecash-lib-integration-tests · build-without-wallet · build-clang · build-chronik · build-chronik-plugins · build-clang-tidy · build-debug
Build 64003: arc lint + arc unit

Event Timeline

PiRK created this revision.Thu, Jan 30, 13:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 30, 13:02

PiRK requested review of this revision.Thu, Jan 30, 13:02

Harbormaster completed remote builds in B32257: Diff 52446.Thu, Jan 30, 13:21

PiRK mentioned this in D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.Thu, Jan 30, 14:03

PiRK added a child revision: D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.Thu, Jan 30, 14:45

Fabien retitled this revision from [chronik] return empty transcation history for an unknown scripthash to [chronik] return empty transaction history for an unknown scripthash.Thu, Jan 30, 20:37

Fabien accepted this revision.Thu, Jan 30, 20:50

Fabien added a subscriber: Fabien.

Fabien added inline comments.