Paths

Table of Contentst

Differential D17621

[ecash-lib] Patch import in `mnemonic.ts`
ClosedPublic
Actions

Authored by tobias_ruck on Fri, Jan 31, 20:49.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC2ccbb46a96c1: [ecash-lib] Patch import in `mnemonic.ts`

Summary

Here we imported from indexNodeJs.ts by accident, which breaks browser builds

Test Plan

npm test, also the bundle should now work in browser environments again...

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Fri, Jan 31, 20:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jan 31, 20:49

include diff url

bytesofman accepted this revision.Fri, Jan 31, 20:53

This revision is now accepted and ready to land.Fri, Jan 31, 20:53

Harbormaster completed remote builds in B32276: Diff 52476.Fri, Jan 31, 20:57

Harbormaster completed remote builds in B32277: Diff 52477.Fri, Jan 31, 21:01

Closed by commit rABC2ccbb46a96c1: [ecash-lib] Patch import in `mnemonic.ts` (authored by tobias_ruck). · Explain WhyFri, Jan 31, 21:03

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC2ccbb46a96c1: [ecash-lib] Patch import in `mnemonic.ts`.

Revision Contents
Changeset List

Path

Size

modules/

ecash-lib/

README.md

1 line

package-lock.json

4 lines

package.json

2 lines

src/

mnemonic.ts

2 lines

Diff 52478

View Options

modules/ecash-lib/README.md

View Options

modules/ecash-lib/package-lock.json

View Options

modules/ecash-lib/package.json

View Options

modules/ecash-lib/src/mnemonic.ts

[ecash-lib] Patch import in `mnemonic.ts`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 52478

modules/ecash-lib/README.md

modules/ecash-lib/package-lock.json

modules/ecash-lib/package.json

modules/ecash-lib/src/mnemonic.ts

[ecash-lib] Patch import in `mnemonic.ts`
ClosedPublic
Actions

Revision Contents
Changeset List