Page MenuHomePhabricator
Differential D17623

[ecash-lib] Better behavior of withPrefix() method in Address class
ClosedPublic
Actions

Authored by bytesofman on Fri, Jan 31, 23:45.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC12cff4fe1b5c: [ecash-lib] Better behavior of withPrefix() method in Address class
Summary

We could expect a user to call withPrefix("ecash:") on, say, every address in an array of ecash: addresses to ensure they all have the same prefix. Better to return unchanged if no prefix change than to throw an error. Do it that way.

Test Plan

npm test, CI

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Fri, Jan 31, 23:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jan 31, 23:45
bytesofman added inline comments.Fri, Jan 31, 23:46
modules/ecash-lib/src/address/address.test.ts
592 ↗(On Diff #52483)

this test description is copypasta, tho the test is right. we also fix this.

tobias_ruck added a subscriber: tobias_ruck.Fri, Jan 31, 23:47
tobias_ruck added inline comments.
modules/ecash-lib/src/address/address.ts
324–327 ↗(On Diff #52483)

how about

bytesofman updated this revision to Diff 52484.Fri, Jan 31, 23:48
bytesofman marked an inline comment as done.

take suggestion, return this instead of new construction

modules/ecash-lib/src/address/address.ts
324–327 ↗(On Diff #52483)

much better, done

Harbormaster completed remote builds in B32281: Diff 52483.Fri, Jan 31, 23:56
Harbormaster completed remote builds in B32282: Diff 52484.
bytesofman published this revision for review.Sat, Feb 1, 00:00
PiRK accepted this revision.Mon, Feb 3, 08:15
This revision is now accepted and ready to land.Mon, Feb 3, 08:15
Closed by commit rABC12cff4fe1b5c: [ecash-lib] Better behavior of withPrefix() method in Address class (authored by bytesofman). · Explain WhyMon, Feb 3, 12:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC12cff4fe1b5c: [ecash-lib] Better behavior of withPrefix() method in Address class.

Revision Contents
Changeset List

PathSize
modules/
ecash-lib/
1 line
4 lines
2 lines
src/
address/
10 lines
2 lines

Diff 52505

View Options

modules/ecash-lib/README.md

Loading...
View Options

modules/ecash-lib/package-lock.json

Loading...
View Options

modules/ecash-lib/package.json

Loading...
View Options

modules/ecash-lib/src/address/address.test.ts

Loading...
View Options

modules/ecash-lib/src/address/address.ts

Loading...