Page MenuHomePhabricator
Differential D17625

[Cashtab] Always show send button on send screen
Needs RevisionPublic
Actions

Authored by bytesofman on Sat, Feb 1, 23:16.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

T3724

Make sure the Send button is always visible. User can still scroll to review tx.

Test Plan

npm test

check out the test site to see how it looks / works

https://cashtab-local-dev.netlify.app/

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendbtn-always-on-top
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32287
Build 64064: Build Diffcashtab-tests
Build 64063: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sat, Feb 1, 23:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Feb 1, 23:16
Harbormaster completed remote builds in B32287: Diff 52490.Sat, Feb 1, 23:22
bytesofman edited the test plan for this revision. (Show Details)Sat, Feb 1, 23:35
bytesofman published this revision for review.Sat, Feb 1, 23:48
bytesofman updated this revision to Diff 52491.Sat, Feb 1, 23:54

version bump + extension bump

Harbormaster completed remote builds in B32288: Diff 52491.Sat, Feb 1, 23:59
emack requested changes to this revision.Sun, Feb 2, 05:00
emack added a subscriber: emack.

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

This revision now requires changes to proceed.Sun, Feb 2, 05:00

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Send/
40 lines
24 lines

Diff 52490

View Options

cashtab/src/components/Send/SendXec.tsx

Loading...
View Options

cashtab/src/components/Send/styled.ts

Loading...