Page MenuHomePhabricator

[Cashtab] Do not wordbreak break-all for XECX summaries
ClosedPublic

Authored by bytesofman on Sun, Feb 2, 19:41.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC94b85cf554c2: [Cashtab] Do not wordbreak break-all for XECX summaries
Summary

We use "break-all" for app actions as, most of the time, the content is unknown; it depends on what a user puts in a tx field. So we can have long strings like addresses that we need to "break-all" on, otherwise we get huge overflows that make the app look broken.

I have been seeing screenshots of "break-all" applied to XECX reward summaries which looks dumb. This is a hard-coded string and we do not need to worry about overflow issues.

So, do not "break all" for this specific app action. Add a prop that can control this behavior in other app actions as we uncover others that have this same issue.

Test Plan

npm test, screenshots

before:

image.png (146×490 px, 21 KB)

after:

image.png (149×523 px, 21 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
xecx-no-wordbreakall
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32294
Build 64078: Build Diffcashtab-tests
Build 64077: arc lint + arc unit