chainparams: add blockhash to AssumeutxoData
ClosedPublic
Actions

Authored by PiRK on Tue, Feb 4, 14:25.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC1d28ffc21aad: chainparams: add blockhash to AssumeutxoData

Summary

This allows us to reference assumeutxo configuration by blockhash as
well as height; this is helpful in future changes when we want to
reference assumeutxo configurations before the block index is loaded.

Also remove the unused assumeutxo checkpoint for block 210.

This is a partial backport of core#27596

https://github.com/bitcoin/bitcoin/pull/27596/commits/434495a8c1496ca23fe35b84499f3daf668d76b8

Depends on D17633

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Tue, Feb 4, 14:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 4, 14:25

PiRK requested review of this revision.Tue, Feb 4, 14:25

teamcity edited the summary of this revision. (Show Details)Tue, Feb 4, 14:25

Note that the feature_deterministic_chain_setup.py test only exists in Bitcoin ABC, Bitcoin Core does not have it. We added it to demonstrate that the hardcoded regtests chainparams (block hashes and txoutsetinfo), which differ from Core due to differences in the block header format, are actually correct.

Harbormaster completed remote builds in B32305: Diff 52514.Tue, Feb 4, 14:50

PiRK edited the summary of this revision. (Show Details)Wed, Feb 5, 18:56

roqqit accepted this revision.Wed, Feb 5, 19:03

This revision is now accepted and ready to land.Wed, Feb 5, 19:03

Closed by commit rABC1d28ffc21aad: chainparams: add blockhash to AssumeutxoData (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyThu, Feb 6, 07:40

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1d28ffc21aad: chainparams: add blockhash to AssumeutxoData.