Page MenuHomePhabricator

[chronik] Add block_and_blocks to bitcoinsuite-chronik-client
Needs ReviewPublic

Authored by hazzarust on Sat, Feb 8, 19:59.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Depends on D17595 - this diff uses features from D17595 such as the test_runner and handler.

Tests verify block and blocks range retrieval from the Chronik client. They check:

  • Block retrieval by height and hash.
  • Block order and consistency in ranges.
  • Error handling for invalid, parked, or invalidated blocks.

This ensures the Chronik client correctly handles block queries and edge cases.

Added detailed comments from TypeScript tests to Rust code, aligned test logic, and ensured error handling and block order validation.

Test Plan

Please set BUILD_DIR env to export BUILD_DIR="/path/to/build_dir
UNIX: ./contrib/teamcity/build-configurations.py build-bitcoinsuite-chronik-client
cd modules/bitcoinsuite-chronik-client && cargo test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
block_and_blocks
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:57WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:64WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:67WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:72WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:75WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:83WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:91WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:98WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:101WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:106WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:109WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:122WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:129WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:132WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:135WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:140WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:148WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:157WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:164WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:167WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:172WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:180WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:189WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:196WHITESPACE1Found trailing whitespace(s).
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/block_and_blocks.rs:199WHITESPACE1Found trailing whitespace(s).
Unit
No Test Coverage
Build Status
Buildable 32359
Build 64207: Build Diffbuild-explorer · chronik-client-integration-tests · build-chronik · ecash-lib-integration-tests · build-bitcoinsuite-chronik-client · ecash-agora-integration-tests · build-chronik-plugins
Build 64206: arc lint + arc unit