Page MenuHomePhabricator
Differential D17662

Make it possible to disable Tor binds and abort startup on bind failure
ClosedPublic
Actions

Authored by Fabien on Feb 12 2025, 22:37.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC7b83b32c468e: Make it possible to disable Tor binds and abort startup on bind failure
Summary
Make it possible to disable the Tor binding on 127.0.0.1:8334 and stop startup if any P2P bind fails instead of "if all P2P binds fail".

Backport of core#22729.

Depends on D17661.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 12 2025, 22:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 12 2025, 22:37
Fabien requested review of this revision.Feb 12 2025, 22:37
teamcity edited the summary of this revision. (Show Details)Feb 12 2025, 22:38
Harbormaster completed remote builds in B32390: Diff 52629.Feb 12 2025, 22:48
PiRK accepted this revision.Feb 13 2025, 11:24
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/test_framework/util.py
328 ↗(On Diff #52629)

Let's hope this is not going to bring us into the port range used by docker

This revision is now accepted and ready to land.Feb 13 2025, 11:24
Closed by commit rABC7b83b32c468e: Make it possible to disable Tor binds and abort startup on bind failure (authored by Vasil Dimov <vd@FreeBSD.org>, committed by Fabien). · Explain WhyFeb 13 2025, 12:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7b83b32c468e: Make it possible to disable Tor binds and abort startup on bind failure.
PiRK mentioned this in D17673: test: Add explicit onion bind to p2p_permissions.Feb 18 2025, 13:19
PiRK mentioned this in rABC9205e1004401: test: Add explicit onion bind to p2p_permissions.Feb 18 2025, 14:46

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
2 lines
40 lines
test/
functional/
21 lines
test_framework/
17 lines
12 lines

Diff 52636

View Options

doc/test-shell.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

test/functional/feature_bind_extra.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...