Differential D1768

Skip sys::system(...) call in case of empty command
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2018, 17:46.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc945c82c6ea7: Skip sys::system(...) call in case of empty command
rABCc945c82c6ea7: Skip sys::system(...) call in case of empty command

Summary

This is part of Core PR10939

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

utilskipemptycmd

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3270
Build 4627: Bitcoin ABC Buildbot (legacy)
Build 4626: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2018, 17:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2018, 17:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3270: Diff 4880.Sep 11 2018, 18:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Not sure why we're doing any system cmds.. :/

This revision is now accepted and ready to land.Sep 15 2018, 15:02

Closed by commit rABCc945c82c6ea7: Skip sys::system(...) call in case of empty command (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhySep 15 2018, 16:57

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

6 lines

Diff 4880

src/util.cpp

Loading...