Page MenuHomePhabricator

Avoid inflight polls in getavaaddr_interval_test
ClosedPublic

Authored by Fabien on Tue, Feb 25, 15:18.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABC7cab3cee14ab: Avoid inflight polls in getavaaddr_interval_test
Summary

Inflight polls during the availability score retrieval can cause the value to change and the test to fail reaching the expected condition. Fix this by exhausing the polls before checking the score (which might be zero but not negative because our peers always answer the polls).

Test Plan
./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_getavaaddr_inflight_polls
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32482
Build 64452: Build Diffbuild-clang · build-clang-tidy · build-debug · build-diff · build-without-wallet
Build 64451: arc lint + arc unit