Differential D17698

Avoid inflight polls in getavaaddr_interval_test
ClosedPublic
Actions

Authored by Fabien on Tue, Feb 25, 15:18.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC7cab3cee14ab: Avoid inflight polls in getavaaddr_interval_test

Summary

Inflight polls during the availability score retrieval can cause the value to change and the test to fail reaching the expected condition. Fix this by exhausing the polls before checking the score (which might be zero but not negative because our peers always answer the polls).

Test Plan

./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Tue, Feb 25, 15:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 25, 15:18

Fabien requested review of this revision.Tue, Feb 25, 15:18

Harbormaster completed remote builds in B32482: Diff 52757.Tue, Feb 25, 15:27

roqqit accepted this revision.Tue, Feb 25, 16:31

This revision is now accepted and ready to land.Tue, Feb 25, 16:31

Closed by commit rABC7cab3cee14ab: Avoid inflight polls in getavaaddr_interval_test (authored by Fabien). · Explain WhyTue, Feb 25, 20:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7cab3cee14ab: Avoid inflight polls in getavaaddr_interval_test.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_getavaaddr.py

17 lines

Diff 52763

View Options

test/functional/abc_p2p_getavaaddr.py

Avoid inflight polls in getavaaddr_interval_testClosedPublicActions